Jeremy Redburn (jredburn) wrote in fotobilder,
Jeremy Redburn
jredburn
fotobilder

Patch submittal

Ok, I've implemented the palette-on-the-fly stuff for PNGs. Would someone be willing to walk me through the process of creating a patch from my changed file? (the only file I changed is Pic.pm)

If you'd like to see it in action:

Original image:
http://fb.mutualslump.net/jeremy/pic/00002abe


Change palette entry 0 to black
http://fb.mutualslump.net/jeremy/pic/00002abe/p0000000


Change palette entry 0 to black and 1 to white
http://fb.mutualslump.net/jeremy/pic/00002abe/p00000001ffffff


A couple of questions for Brad regarding his implementation:
- Is it possible to change the palette entry for palette entries > 15 (F)? It seems not since we're looking for multiples of 7 for each change
- I do some error checking of the PNG (ie. check for valid signature, make sure png type is indexed palette). Is the "right" way to react to errors to return 404?

A few final notes:
- Right now it breaks if you try and change a nonexisting palette entry (PNGs don't have fixed size palettes). The test image only has entries 0 and 1. I'll fix this before I submit the patch.

thanks,
jeremy

Updated: The patch is now available here.
Subscribe

  • 302: lj_dev

    In the interests of consolidating all FotoBilder development-related discussion, we're going to be closing down this community. The same…

  • Development stalled?

    Is the development of Fotobilder held? Stalled? I am asking because there is no activity on the community and there is no link to the Fotobilder…

  • (no subject)

    Does FotoBilder works with Apache2? I installed all the required modules on my debian sarge, and when I restart my apache server, it dies horribly…

  • Post a new comment

    Error

    Comments allowed for members only

    Anonymous comments are disabled in this journal

    default userpic
  • 14 comments

  • 302: lj_dev

    In the interests of consolidating all FotoBilder development-related discussion, we're going to be closing down this community. The same…

  • Development stalled?

    Is the development of Fotobilder held? Stalled? I am asking because there is no activity on the community and there is no link to the Fotobilder…

  • (no subject)

    Does FotoBilder works with Apache2? I installed all the required modules on my debian sarge, and when I restart my apache server, it dies horribly…